Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(observer): isSupported to isActive #1545

Closed
wants to merge 4 commits into from
Closed

refactor(observer): isSupported to isActive #1545

wants to merge 4 commits into from

Conversation

Shenr0n
Copy link

@Shenr0n Shenr0n commented Jan 9, 2024 •
edited
Loading

Fixes #1523

@Shenr0n Shenr0n changed the title isSupported to isActive isSupported to isActive - refactor Jan 9, 2024
@Shenr0n Shenr0n changed the title isSupported to isActive - refactor - refactor isSupported to isActive Jan 9, 2024
@Shenr0n Shenr0n changed the title - refactor isSupported to isActive refactor(good first issue): isSupported to isActive Jan 9, 2024
@kingpinXD
Copy link
Contributor

Please run

  • make generate to make sure you pass generated files check
  • add a changelog entry to clear the changelog check

@kingpinXD kingpinXD removed the backlog label Jan 10, 2024
@lumtis lumtis changed the title refactor(good first issue): isSupported to isActive refactor(observer): isSupported to isActive Jan 11, 2024
kingpinXD
kingpinXD requested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would also need to have a migration script to for params . To transition from the old to the new fields .
Lets hold on to this PR for now , and the script can be added after the transition to chain params has been merged to develop

@lumtis
Copy link
Member

lumtis commented Feb 26, 2024

It looks inactive.
Closing for now to give a chance if someone else want to address the issue.
Please, feel free to reopen.

@lumtis lumtis closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingpinXD kingpinXD kingpinXD requested changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@fadeev fadeev Awaiting requested review from fadeev

@lumtis lumtis Awaiting requested review from lumtis

@ws4charlie ws4charlie Awaiting requested review from ws4charlie

Assignees
No one assigned
Labels
breaking:proto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CoreParams: Rename IsSupported into IsActive
3 participants
@Shenr0n @kingpinXD @lumtis